sheetjs/js-codepage
1
Fork 0
Code Issues 5 Pull Requests 1 Projects Releases Wiki Activity

Use version ~2.14.1 of commander #15

Merged
davidvetrano merged 1 commits from fix-commander-version into master 2018-02-21 02:35:28 +00:00
Conversation 3 Commits 1 Files Changed 1 +2 -2
davidvetrano commented 2018-02-21 02:31:48 +00:00 (Migrated from github.com)
Copy Link

Hi there,

The version of commander specified in the last package json is invalid. I updated it to the latest version which seems to have no breaking changes although I have not run the test suite.

Cheers,
David

Hi there, The version of commander specified in the last package json is invalid. I updated it to the latest version which seems to have no breaking changes although I have not run the test suite. Cheers, David
SheetJSDev commented 2018-02-21 02:34:14 +00:00 (Migrated from github.com)
Copy Link

Thanks for the heads up, we unpublished and will publish the next version

Thanks for the heads up, we unpublished and will publish the next version
davidvetrano commented 2018-02-21 02:38:48 +00:00 (Migrated from github.com)
Copy Link

Thanks! I don't think that @types/commander is needed as a dependency but I updated that too since it was already depended on.

Thanks! I don't think that `@types/commander` is needed as a dependency but I updated that too since it was already depended on.
SheetJSDev commented 2018-02-21 02:45:49 +00:00 (Migrated from github.com)
Copy Link

Ok 1.12.2 should be live on NPM and 1.12.1 was unpublished.

The @types/commander dev dependency is needed for the TS definition tests (https://github.com/SheetJS/js-codepage/blob/master/types/bin_codepage.ts is a TS-ified version of the bin script). In the same vein, commander is only needed for the bin script, but npm provides no way of specifying whether the bin scripts should be installed.

Ok 1.12.2 should be live on NPM and 1.12.1 was unpublished. The `@types/commander` dev dependency is needed for the TS definition tests (https://github.com/SheetJS/js-codepage/blob/master/types/bin_codepage.ts is a TS-ified version of the bin script). In the same vein, `commander` is only needed for the bin script, but npm provides no way of specifying whether the bin scripts should be installed.
👍 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/js-codepage#15
No description provided.
Delete Branch "fix-commander-version"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?