build_full_paths does not prepend "root_entry/" if child is before parent #5

New Issue

2018-12-12T17:46:04Z

rossj commented

2018-12-12 17:46:04 +00:00

(Migrated from github.com)

I came across and issue where the returned FullPaths array from a cfb.parse call does not properly append the root name (root_entry/) to child nodes (with depth greater than 1) that appear before their parent node.

It seems that in such a situation, build_full_paths properly constructs the dad tree, but terminates the final path construction loop too early, before it has prepended root_entry/.

I have created and attached a sample file the demonstrates the issue.

The returned FullPaths array is:

[
    "Root Entry/",
    "some folder/some child",
    "Root Entry/some folder/"
]

Despite "some child" being a child of "some folder"

Here is the view from DFVIEW.EXE

path-test.zip

I came across and issue where the returned `FullPaths` array from a `cfb.parse` call does not properly append the root name (`root_entry/`) to child nodes (with depth greater than 1) that appear before their parent node. It seems that in such a situation, `build_full_paths` properly constructs the `dad` tree, but terminates the final path construction loop too early, before it has prepended `root_entry/`. I have created and attached a sample file the demonstrates the issue. The returned `FullPaths` array is: ```javascript [ "Root Entry/", "some folder/some child", "Root Entry/some folder/" ] ``` Despite "some child" being a child of "some folder" Here is the view from DFVIEW.EXE ![image](https://user-images.githubusercontent.com/735679/49888023-eb440900-fe0b-11e8-8180-85ef7d623099.png) [path-test.zip](https://github.com/SheetJS/js-cfb/files/2672924/path-test.zip)

Sign in to join this conversation.