sheetjs/js-cfb
1
Fork 0
Code Issues 3 Pull Requests Projects Releases Wiki Activity

Bad parenting / hierarchy construction when parent is after R / L sibling tree #15

New Issue
Open
opened 2021-12-28 21:29:41 +00:00 by rossj · 0 comments
rossj commented 2021-12-28 21:29:41 +00:00 (Migrated from github.com)
Copy Link

I've noticed some files that show an incorrect folder structure with this library. I believe the dad array is not filled correctly when a node comes before it's parent, and has R or L sibling nodes. I've attached a sample file that demonstrates the issue.

In the attached .cfb file, both some file 1 and some file 2 are sibling files under some folder, but js-cfb shows some file 2 as a root level file.

image

file.zip

I've noticed some files that show an incorrect folder structure with this library. I believe the `dad` array is not filled correctly when a node comes before it's parent, and has R or L sibling nodes. I've attached a sample file that demonstrates the issue. In the attached .cfb file, both `some file 1` and `some file 2` are sibling files under `some folder`, but js-cfb shows `some file 2` as a root level file. ![image](https://user-images.githubusercontent.com/735679/147608230-c53914bd-da3e-4645-837b-8a1a94ccb6c7.png) [file.zip](https://github.com/SheetJS/js-cfb/files/7786383/file.zip)
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels   
bug

   
duplicate

   
enhancement

   
invalid

   
question

   
wontfix
No Label
bug
duplicate
enhancement
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: sheetjs/js-cfb#15
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?