From 3e8d553a5832ea5a87c496e3950a62dc38e78c68 Mon Sep 17 00:00:00 2001 From: Asad Date: Thu, 15 Jan 2026 21:51:29 -0500 Subject: [PATCH] fix: issue:4 --- CHANGELOG.md | 5 +++++ package.json | 2 +- src/excelEditorProvider.ts | 13 ++++++------- 3 files changed, 12 insertions(+), 8 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 8010f29..12770f4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,11 @@ All notable changes to the "sheetjs-demo" extension will be documented in this file. +## [0.1.2] + +### Fixed +- Fixed row count issues after reopening files or switching worksheets, and corrected range calculation when sheets load from cache. + ## [0.1.1] - Added control over #rows x #columns to show - Added control over #worbooks and #worksheets to cache diff --git a/package.json b/package.json index a202de1..7b573d8 100644 --- a/package.json +++ b/package.json @@ -5,7 +5,7 @@ "author": "Asadbek Karimov ", "publisher": "asadbek", "icon": "img/logo.png", - "version": "0.1.1", + "version": "0.1.2", "license": "Apache-2.0", "bugs": { "url": "https://git.sheetjs.com/asadbek064/sheetjs-vscode-extension/issues" diff --git a/src/excelEditorProvider.ts b/src/excelEditorProvider.ts index 0eac9bb..71ecc03 100644 --- a/src/excelEditorProvider.ts +++ b/src/excelEditorProvider.ts @@ -262,19 +262,18 @@ export class ExcelEditorProvider implements vscode.CustomReadonlyEditorProvider< // setTimeout to ensure loading message gets displayed setTimeout(async () => { try { + const sheet = workbook.Sheets[sheetName]; + + // always calculate range info + const range = sheet['!ref'] || ''; + const rangeInfo = parseRange(range); + let sheetHtml: string; - let rangeInfo: any = null; // check if this page is already cached if (this.cache.hasSheet(cacheKey)) { sheetHtml = this.cache.getSheet(cacheKey)!; } else { - const sheet = workbook.Sheets[sheetName]; - - // get the range of the sheet (e.g., A1:Z100) - const range = sheet['!ref'] || ''; - rangeInfo = parseRange(range); - if (!rangeInfo) { sheetHtml = '

No data in this sheet

'; } else {