From 07f3a55695674d91985d8131bbbec7f27f87da69 Mon Sep 17 00:00:00 2001
From: Kenny Daniel <platypii@gmail.com>
Date: Sun, 28 Jan 2024 00:08:36 -0800
Subject: [PATCH] Fix string conversion with a dictionary

---
 src/column.js | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/column.js b/src/column.js
index 2f0524a..3d289a0 100644
--- a/src/column.js
+++ b/src/column.js
@@ -119,6 +119,7 @@ export function readColumn(arrayBuffer, rowGroup, columnMetadata, schema) {
           for (let i = 0; i < dataPage.length; i++) {
             values[i] = dictionary[dataPage[i]]
           }
+          values = convert(values, schemaElement(schema, columnMetadata.path_in_schema))
         } else if (Array.isArray(dataPage)) {
           // convert primitive types to rich types
           values = convert(dataPage, schemaElement(schema, columnMetadata.path_in_schema))
@@ -172,7 +173,7 @@ export function getColumnOffset(columnMetadata) {
  */
 function convert(data, schemaElement) {
   const ctype = schemaElement.converted_type
-  if (!ctype) return data
+  if (ctype === undefined) return data
   if (ctype === ConvertedType.UTF8) {
     const decoder = new TextDecoder()
     return data.map(v => decoder.decode(v))