From 3729f4cb5e76e2854b72dcd302e0a5371f61a6d2 Mon Sep 17 00:00:00 2001
From: Kenny Daniel <platypii@gmail.com>
Date: Mon, 31 Mar 2025 23:32:14 -0700
Subject: [PATCH] Use constants from hyparquet

---
 README.md            |  2 +-
 package.json         |  6 ++++--
 src/metadata.js      | 13 +------------
 src/types.d.ts       |  5 -----
 src/write.js         |  3 ++-
 test/package.test.js |  8 ++++----
 6 files changed, 12 insertions(+), 25 deletions(-)

diff --git a/README.md b/README.md
index 6106524..de21e5c 100644
--- a/README.md
+++ b/README.md
@@ -5,7 +5,7 @@
 [![workflow status](https://github.com/hyparam/hyparquet-writer/actions/workflows/ci.yml/badge.svg)](https://github.com/hyparam/hyparquet-writer/actions)
 [![mit license](https://img.shields.io/badge/License-MIT-orange.svg)](https://opensource.org/licenses/MIT)
 ![coverage](https://img.shields.io/badge/Coverage-96-darkred)
-[![dependencies](https://img.shields.io/badge/Dependencies-0-blueviolet)](https://www.npmjs.com/package/hyparquet?activeTab=dependencies)
+[![dependencies](https://img.shields.io/badge/Dependencies-1-blueviolet)](https://www.npmjs.com/package/hyparquet-writer?activeTab=dependencies)
 
 ## Usage
 
diff --git a/package.json b/package.json
index 1ca54c6..bb2b41e 100644
--- a/package.json
+++ b/package.json
@@ -39,13 +39,15 @@
     "prepare": "npm run build:types",
     "test": "vitest run"
   },
+  "dependencies": {
+    "hyparquet": "1.10.2"
+  },
   "devDependencies": {
     "@babel/eslint-parser": "7.27.0",
-    "@types/node": "22.13.14",
+    "@types/node": "22.13.17",
     "@vitest/coverage-v8": "3.1.1",
     "eslint": "9.23.0",
     "eslint-plugin-jsdoc": "50.6.9",
-    "hyparquet": "1.10.1",
     "typescript": "5.8.2",
     "vitest": "3.1.1"
   }
diff --git a/src/metadata.js b/src/metadata.js
index cd00041..742c176 100644
--- a/src/metadata.js
+++ b/src/metadata.js
@@ -1,17 +1,6 @@
-import { ConvertedType, Encoding, FieldRepetitionType, PageType, ParquetType } from 'hyparquet/src/constants.js'
+import { CompressionCodec, ConvertedType, Encoding, FieldRepetitionType, PageType, ParquetType } from 'hyparquet/src/constants.js'
 import { serializeTCompactProtocol } from './thrift.js'
 
-const CompressionCodec = [
-  'UNCOMPRESSED',
-  'SNAPPY',
-  'GZIP',
-  'LZO',
-  'BROTLI',
-  'LZ4',
-  'ZSTD',
-  'LZ4_RAW',
-]
-
 /**
  * @import {FileMetaData} from 'hyparquet'
  * @import {Writer} from './writer.js'
diff --git a/src/types.d.ts b/src/types.d.ts
index 617de1c..793dd90 100644
--- a/src/types.d.ts
+++ b/src/types.d.ts
@@ -6,11 +6,6 @@ export interface ColumnData {
   type?: ParquetType
 }
 
-export interface KeyValue {
-  key: string
-  value?: string
-}
-
 export interface Writer {
   buffer: ArrayBuffer
   offset: number
diff --git a/src/write.js b/src/write.js
index 12bf9ec..9758998 100644
--- a/src/write.js
+++ b/src/write.js
@@ -7,7 +7,8 @@ import { getSchemaElementForValues } from './schema.js'
  * Write data as parquet to an ArrayBuffer
  *
  * @import {ColumnChunk, DecodedArray, FileMetaData, SchemaElement, SchemaTree} from 'hyparquet'
- * @import {ColumnData, KeyValue} from '../src/types.js'
+ * @import {KeyValue} from 'hyparquet/src/types.js'
+ * @import {ColumnData} from '../src/types.js'
  * @param {object} options
  * @param {ColumnData[]} options.columnData
  * @param {boolean} [options.compressed]
diff --git a/test/package.test.js b/test/package.test.js
index d1c3e28..a68612a 100644
--- a/test/package.test.js
+++ b/test/package.test.js
@@ -12,13 +12,13 @@ describe('package.json', () => {
     expect(packageJson.license).toBe('MIT')
   })
   it('should have precise dev dependency versions', () => {
-    const { devDependencies } = packageJson
-    Object.values(devDependencies).forEach(version => {
+    const { dependencies, devDependencies } = packageJson
+    const allDependencies = { ...dependencies, ...devDependencies }
+    Object.values(allDependencies).forEach(version => {
       expect(version).toMatch(/^\d+\.\d+\.\d+$/)
     })
   })
-  it('should have no dependencies', () => {
-    expect('dependencies' in packageJson).toBe(false)
+  it('should have no peer dependencies', () => {
     expect('peerDependencies' in packageJson).toBe(false)
   })
 })